Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: fix async initialization #724

Closed
wants to merge 2 commits into from
Closed

Conversation

atk
Copy link
Member

@atk atk commented Dec 9, 2024

See #708

Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: d07272f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-primitives/storage Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@atk atk requested a review from thetarnav December 9, 2024 12:16
@thetarnav
Copy link
Member

Can you explain why the setter has to be ran with owner? I don't think that signal setters use the current owner at all. Which makes sense as they should be used generally on user events where there is no reactive context.

@atk atk closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants