Unused Spree::Order#temporary_payment_source attribute

[AlessioRocco]

The Spree::Order attribute temporary_payment_source seems not to be set in any place.
The only line where it's used is:

solidus/core/app/models/spree/wallet/add_payment_sources_to_wallet.rb

Line 16 in 475d9db

if !order.temporary_payment_source && order.user

Do you have any idea on what the purpose of that attribute?

[peterberkenbosch]

it was used to have a choice to have the payment source saved or not. It has since then been unused indeed. Current wip around this attribute is being done here: #2965

[kennyadsl]

I think that saving the source should be done per payment and not per order.

There's no guarantee that the user enters a single payment/source per order, there could be frontends that allow adding more than one credit card in the payment step and user could want to save just a subset of them.

I think we should move the temporary attribute on payments or sources calling it with a better name as well (like single_usage_allowed), this way it will be more flexible.

WDYT?

[peterberkenbosch]

Good call @kennyadsl, I totally agree! Thanks. Will update this PR asap