Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specs failing after Money 6.18.0 release #5680

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

spaghetticode
Copy link
Member

Summary

Money 6.18.0 includes RubyMoney/money#1026 which replaces the html entity for EURO with its symbol.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • [I have used clear, explanatory commit messages.

The release includes RubyMoney/money#1026
which replaces the html entity for EURO with its symbol.
@spaghetticode spaghetticode requested a review from a team as a code owner March 5, 2024 09:59
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Mar 5, 2024
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spaghetticode spaghetticode merged commit 7d380c9 into solidusio:main Mar 6, 2024
11 checks passed
@spaghetticode spaghetticode deleted the spaghetticode/money-fix branch March 6, 2024 06:45
@spaghetticode spaghetticode added the backport-v4.3 Backport this pull-request to v4.3 label Mar 11, 2024
Copy link

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen
Copy link
Member

tvdeyen commented May 8, 2024

This needs to be back ported to 4.2, 4.1 and 4.0 as well, no?

@tvdeyen tvdeyen added backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 labels May 8, 2024
Copy link

github-actions bot commented May 8, 2024

💔 Some backports could not be created

Status Branch Result
v4.0
v4.1
v4.2 An unhandled error occurred. Please see the logs for details
v4.3 Cherrypick failed because the selected commit (2b88945) is empty. It looks like the commit was already backported in #5691

Manual backport

To create the backport manually run:

backport --pr 5680

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

github-actions bot commented May 8, 2024

💔 Some backports could not be created

Status Branch Result
v4.0
v4.1
v4.2
v4.3 Cherrypick failed because the selected commit (2b88945) is empty. It looks like the commit was already backported in #5691

Manual backport

To create the backport manually run:

backport --pr 5680

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

github-actions bot commented May 8, 2024

💔 Some backports could not be created

Status Branch Result
v4.0
v4.1
v4.2
v4.3 Cherrypick failed because the selected commit (2b88945) is empty. It looks like the commit was already backported in #5691

Manual backport

To create the backport manually run:

backport --pr 5680

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants