Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating OTEL client #1

Closed
wants to merge 15 commits into from
Closed

Updating OTEL client #1

wants to merge 15 commits into from

Conversation

ryanrolds
Copy link
Collaborator

@ryanrolds ryanrolds commented Dec 13, 2024

  • Update OTEL client to latest version (1.33)
  • Fixed a few test failure conditions

I have built and confirmed the binary pushes metrics to our OTEL Collector and Cloud Monitoring.

I don't intend to merge this. If my peers approve, I will submit a PR upstream. My default pattern for forks is to keep main in fork the same as upstream.

% go run gotest.tools/gotestsum --format short-verbose -- -timeout=5m ./...
PASS TestGit_ContributeAttributesCloneOptions/local (0.46s)
PASS TestGit_ContributeAttributesCloneOptions/jenkins (0.25s)
PASS TestGit_ContributeAttributesCloneOptions (0.71s)
PASS TestGit_ContributeAttributesForChangeRequests/local (0.28s)
PASS TestGit_ContributeAttributesForChangeRequests/jenkins (0.23s)
PASS TestGit_ContributeAttributesForChangeRequests (0.51s)
PASS TestGit_ContributeAttributesForBranches/local (0.23s)
PASS TestGit_ContributeAttributesForBranches/jenkins (0.23s)
PASS TestGit_ContributeAttributesForBranches (0.46s)
PASS TestGit_ContributeCommitters/local (0.23s)
PASS TestGit_ContributeCommitters/jenkins (0.21s)
PASS TestGit_ContributeCommitters (0.44s)
PASS TestGit_ContributeFilesAndLines/local (0.26s)
PASS TestGit_ContributeFilesAndLines/jenkins (0.23s)
PASS TestGit_ContributeFilesAndLines (0.49s)
PASS TestGit_CalculateCommitsForChangeRequests/local (0.22s)
PASS TestGit_CalculateCommitsForChangeRequests/jenkins (0.28s)
PASS TestGit_CalculateCommitsForChangeRequests (0.50s)
PASS TestGit_CalculateCommitsForBranches/local (0.24s)
PASS TestGit_CalculateCommitsForBranches/jenkins (0.22s)
PASS TestGit_CalculateCommitsForBranches (0.46s)
PASS Test_Main_SampleXML (37.03s)
PASS Test_GetServiceVariable/OTEL_SERVICE_NAME/Without_environment_variable_and_no_flag_retrieves_fallback (0.00s)
PASS Test_GetServiceVariable/OTEL_SERVICE_NAME/With_environment_variable_and_no_flag_retrieves_the_variable (0.00s)
PASS Test_GetServiceVariable/OTEL_SERVICE_NAME/Without_environment_variable_and_flag_retrieves_the_flag (0.00s)
PASS Test_GetServiceVariable/OTEL_SERVICE_NAME/With_environment_variable_and_flag_retrieves_the_flag (0.00s)
PASS Test_GetServiceVariable/OTEL_SERVICE_NAME (0.00s)
PASS Test_GetServiceVariable/OTEL_SERVICE_VERSION/Without_environment_variable_and_no_flag_retrieves_fallback (0.00s)
PASS Test_GetServiceVariable/OTEL_SERVICE_VERSION/With_environment_variable_and_no_flag_retrieves_the_variable (0.00s)
PASS Test_GetServiceVariable/OTEL_SERVICE_VERSION/Without_environment_variable_and_flag_retrieves_the_flag (0.00s)
PASS Test_GetServiceVariable/OTEL_SERVICE_VERSION/With_environment_variable_and_flag_retrieves_the_flag (0.00s)
PASS Test_GetServiceVariable/OTEL_SERVICE_VERSION (0.00s)
PASS Test_GetServiceVariable (0.00s)
PASS TestCheckGitContext/Github/Running_for_Branches (0.00s)
PASS TestCheckGitContext/Github/Running_for_Pull_Requests (0.00s)
PASS TestCheckGitContext/Github (0.00s)
PASS TestCheckGitContext/Jenkins/Running_for_Branches (0.00s)
PASS TestCheckGitContext/Jenkins/Running_for_Pull_Requests (0.00s)
PASS TestCheckGitContext/Jenkins (0.00s)
PASS TestCheckGitContext/Gitlab/Running_for_Branches (0.00s)
PASS TestCheckGitContext/Gitlab/Running_for_Merge_Requests (0.00s)
PASS TestCheckGitContext/Gitlab (0.00s)
PASS TestCheckGitContext/Local_machine/Running_with_TARGET_BRANCH (0.00s)
PASS TestCheckGitContext/Local_machine/Running_without_TARGET_BRANCH (0.00s)
PASS TestCheckGitContext/Local_machine (0.00s)
PASS TestCheckGitContext/Empty_SCM_context (0.00s)
PASS TestCheckGitContext (0.00s)
PASS TestGetScm/This_project_uses_Git (0.00s)
PASS TestGetScm/This_project_does_not_use_Git (0.00s)
PASS TestGetScm (0.00s)
PASS TestGetTargetBranch/For_change-requests_it_must_return_target_branch (0.00s)
PASS TestGetTargetBranch/For_branches_it_must_return_branch (0.00s)
PASS TestGetTargetBranch (0.00s)
PASS .

DONE 53 tests in 42.305s

@ryanrolds ryanrolds marked this pull request as ready for review December 16, 2024 22:37
@ryanrolds ryanrolds requested a review from sheidkamp December 16, 2024 22:54
Copy link

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

main_test.go Show resolved Hide resolved
main.go Show resolved Hide resolved
@ryanrolds ryanrolds closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants