Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdminLTE 3 implementation #5597

Closed
muspelheim opened this issue Jun 20, 2019 · 11 comments
Closed

AdminLTE 3 implementation #5597

muspelheim opened this issue Jun 20, 2019 · 11 comments

Comments

@muspelheim
Copy link
Contributor

Feature Request

Hi, are you planned to implement AdminLTE 3? it looks better than 2 and seems modern

https://adminlte.io/themes/dev/AdminLTE/index.html

@OskarStark
Copy link
Member

No plans yet, but we would highly appreciate it 😍
@silasjoisten is currently working on implementing Webpack Encore in #5461

This should be done afterwards, maybe you can support him

@ElectricMaxxx
Copy link
Contributor

ElectricMaxxx commented Jun 21, 2019 via email

@sonata-project sonata-project deleted a comment from TangMonk Aug 18, 2019
@stale
Copy link

stale bot commented Jan 30, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 30, 2020
@SonataCI SonataCI removed the wontfix label Jan 30, 2020
@wbloszyk
Copy link
Member

Please reopen this issue. I will update AdminLte.

@silasjoisten Do you need help with Webpack? Are you still working on it?

@OskarStark OskarStark reopened this Mar 23, 2020
@wbloszyk
Copy link
Member

@OskarStark Also can You create new temporary branch from master? I think better way for review will be create seperate branch, adding changes in atomic commits and after all rebase it to master branch.

@OskarStark
Copy link
Member

Sure I can, but we should merge Webpack integration first, should we?

@wbloszyk
Copy link
Member

It will be nice if webpack is finished. If not i can update AdminLte(commits: upgrade vendor, update templates...) but after rebase result will be the same.

@wbloszyk
Copy link
Member

@OskarStark
We can push both features to temperary branch and after work done rebase it and marge to master.

@sonata-project/contributors
Like We wrote here:

@OskarStark Also can You create new temporary branch from master? I think better way for review will be create seperate branch, adding changes in atomic commits and after all rebase it to master branch.

Sure I can, but we should merge Webpack integration first, should we?

I check webpack. Last update was in 1 march 2020. I decide to help(or finish it) for @silasjoisten. Can i split it and push as atomic commits? Mark @silasjoisten as co-author will be enough? I dont wanna stealing his work.

Also today I should finish integrate AdminLTE 3 but is should be update after webpack to avoid unnesessery adding vendors.

@OskarStark
Copy link
Member

@silasjoisten can you add @wbloszyk as maintainer to your fork?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 20, 2020
@wbloszyk wbloszyk added keep and removed stale labels Sep 21, 2020
@VincentLanglet
Copy link
Member

Will close in favor of the discussion in #7156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants