Unify js files #7098
Merged
Unify js files #7098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will just leave this open, to notice that I am working on this part of the integration. It is not ready because I am having problems exposing jquery (and its plugins) to the outside world. Any help there would be welcome. @sonata-project/contributors |
jordisala1991
force-pushed
the
feature/unify-js-files
branch
9 times, most recently
from
b1728b4
to
0880884
Compare
31 tasks
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
feature/unify-js-files
branch
from
0880884
to
72eaf86
Compare
|
Fixed the build, and the problems I had before with the utilisation of multiple jQuery versions. Now all node_modules uses the same ^2.x version of jQuery (still pending the upgrade to 3) and all plugins get added correctly and usable from the outside. |
jordisala1991
commented
Apr 23, 2021
VincentLanglet
previously approved these changes
Apr 23, 2021
VincentLanglet
previously approved these changes
Apr 23, 2021
phansys
requested changes
Apr 24, 2021
Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
phansys
previously approved these changes
Apr 24, 2021
Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
VincentLanglet
previously approved these changes
Apr 24, 2021
VincentLanglet
approved these changes
Apr 25, 2021
franmomu
approved these changes
Apr 25, 2021
wbloszyk
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this only applies to master.
Part of #7049
Requires #7089
Changelog