Move Sonata javascript to assets directory #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase your PR and fix merge conflicts? |
|
Just opened the PR to show the progress, we are close to have only one css and js for whole sonata admin bundle exposed. After this one, next step could be move inline scripts to the js file. |
jordisala1991
force-pushed
the
feature/move-sonata-assets
branch
from
be6c174
to
8bd6bb3
Compare
31 tasks
jordisala1991
force-pushed
the
feature/move-sonata-assets
branch
2 times, most recently
from
47932ae
to
6c65a89
Compare
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
feature/move-sonata-assets
branch
from
6add477
to
4d7dc6b
Compare
|
This one is ready @sonata-project/contributors |
VincentLanglet
approved these changes
Apr 26, 2021
franmomu
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this only applies to master.
Part of #7049
Changelog