Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve linting of assets #7113

Merged
merged 4 commits into from
Apr 28, 2021

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Apr 25, 2021

Subject

I am targeting this branch, because this only applies to master.

Part of #7049

Requires #7109

@jordisala1991 jordisala1991 mentioned this pull request Apr 25, 2021
31 tasks
@jordisala1991 jordisala1991 force-pushed the hotfix/better-lint branch 3 times, most recently from 8004541 to 25a7671 Compare April 26, 2021 07:15
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@jordisala1991 jordisala1991 changed the title Improve linting of Javascript files with airbnb eslint configuration Improve linting of assets Apr 27, 2021
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@jordisala1991 jordisala1991 marked this pull request as ready for review April 28, 2021 07:15
@jordisala1991 jordisala1991 requested a review from a team April 28, 2021 07:15
@greg0ire greg0ire merged commit b87f72c into sonata-project:master Apr 28, 2021
@greg0ire
Copy link
Contributor

Thanks @jordisala1991 !

@jordisala1991 jordisala1991 deleted the hotfix/better-lint branch April 28, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants