-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve linting of assets #7113
Merged
greg0ire
merged 4 commits into
sonata-project:master
from
jordisala1991:hotfix/better-lint
Apr 28, 2021
Merged
Improve linting of assets #7113
greg0ire
merged 4 commits into
sonata-project:master
from
jordisala1991:hotfix/better-lint
Apr 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
jordisala1991
force-pushed
the
hotfix/better-lint
branch
3 times, most recently
from
April 26, 2021 07:15
8004541
to
25a7671
Compare
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
hotfix/better-lint
branch
from
April 27, 2021 07:03
25a7671
to
8440b20
Compare
jordisala1991
changed the title
Improve linting of Javascript files with airbnb eslint configuration
Improve linting of assets
Apr 27, 2021
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
hotfix/better-lint
branch
from
April 28, 2021 06:33
8440b20
to
ed5b92e
Compare
jordisala1991
force-pushed
the
hotfix/better-lint
branch
from
April 28, 2021 06:35
ed5b92e
to
005e457
Compare
jordisala1991
force-pushed
the
hotfix/better-lint
branch
from
April 28, 2021 07:15
b449f55
to
c5b3c3a
Compare
core23
approved these changes
Apr 28, 2021
Thanks @jordisala1991 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this only applies to master.
Part of #7049
Requires #7109