Avoid accidental removal of some frontend dependencies #7140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
force-pushed
the
hotfix/remove-scroll-to
branch
from
6e23636
to
aad4fdb
Compare
jordisala1991
changed the title
VincentLanglet
previously approved these changes
May 1, 2021
jordisala1991
force-pushed
the
hotfix/remove-scroll-to
branch
from
27577f2
to
4bbc9c3
Compare
VincentLanglet
approved these changes
May 1, 2021
OskarStark
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is only applies to master.
Part of #7049
I tried to remove jquery-slimScroll and jquery-scrollTo but found that they are used outside this bundle:
jquery-slimScroll is kind of used for admin-lte
jquery-scrollTo is used by other sonata bundles
I just added some explanations to the javascript, just in case someone tries to remove them. Ideally the dependencies should be placed where the usage is done, but for now this is better than nothing.
I also added postcss, it was a missing dependency