Improve jQuery code #7141
Improve jQuery code #7141
Conversation
Avoid some deprecations and use anonymous functions as much as possible. Try to avoid using this, and instead use the parameters passed to the function.
| @@ -48,7 +48,7 @@ const Admin = { | |||
| } | |||
| }, | |||
| read_config() { | |||
| const data = $('[data-sonata-admin]').data('sonata-admin'); | |||
| const data = jQuery('[data-sonata-admin]').data('sonata-admin'); | |||
There was a problem hiding this comment.
Some consistency here, try to use always jQuery so it can be easily identified
| @@ -94,8 +94,8 @@ const Admin = { | |||
| if (Admin.get_config('USE_SELECT2')) { | |||
| Admin.log('[core|setup_select2] configure Select2 on', subject); | |||
|
|
|||
| jQuery('select:not([data-sonata-select2="false"])', subject).each(function eachSetupSelect2() { | |||
| const select = jQuery(this); | |||
| jQuery('select:not([data-sonata-select2="false"])', subject).each((index, element) => { | |||
There was a problem hiding this comment.
arrow functions preferred over normal functions
| checkboxClass: 'icheckbox_square-blue', | ||
| radioClass: 'iradio_square-blue', | ||
| }) | ||
| // See https://github.com/fronteed/iCheck/issues/244 |
There was a problem hiding this comment.
This issue looks like it was solved some time ago
| @@ -190,16 +185,16 @@ const Admin = { | |||
| const isChecked = jQuery(`tbody input[type="checkbox"]:nth(${currentIndex})`, subject).prop('checked'); | |||
|
|
|||
| // Check all checkbox between previous and current one clicked | |||
| jQuery('tbody input[type="checkbox"]', subject).each((i, e) => { | |||
There was a problem hiding this comment.
don't like 1 char var name
|
I think the default airbnb config is just fine. The thing with arrow function is that sometimes (when you use So, at the end we should encourage arrow functions, but there might be some cases where normal functions are needed. Airbnb eslint already takes care when you are trying to use a normal function without using |
Avoid some deprecations and use arrow functions as much as possible.
Try to avoid using this, and instead use the parameters passed to the
function.
Subject
I am targeting this branch, because this is where it can be applied.
Part of #7049
I think it is pedantic since it does not fix any issue, the js deprecations are not showin anywhere. (and probably they are deprecated on 3.0 of jQuery not on 2.0)