Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added all Sonatype Solutions in project metadata #39

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

madpah
Copy link
Contributor

@madpah madpah commented Nov 14, 2024

feat: listed our community generated API Clients for NXRM and IQ

feat: listed our community generated API Clients for NXRM and IQ
Signed-off-by: Paul Horton <phorton@sonatype.com>
@madpah madpah added the documentation Improvements or additions to documentation label Nov 14, 2024
@madpah madpah self-assigned this Nov 14, 2024
@paul-botsco-2-0 paul-botsco-2-0 bot added the 😍 cla signed The CLA is signed label Nov 14, 2024
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Contributor

@eddie-knight eddie-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, really demonstrates the value of the config-based layout!

Sonarqube appears to be a false-negative... The workflow failed, but inside the UI it's marked as passed.

Signed-off-by: Eddie Knight <knight@linux.com>
Copy link
Contributor

@bhamail bhamail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, with one possible tweak

"blobstore"
]
},
{
"name": "API Clients",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to commit marketing blasphemy, but I find these two images "too similar" to be clear. Could differentiate the products in the title, something like: "Nexus Repo API Clients", and "IQ Server API Clients"? Any short product name in front of "API Clients" would suffice: (NXRM, IQ even?)

Screenshot 2024-11-14 at 12 02 03 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhamail - they were previously but the longer names borked the layout formatting...

Open to suggestions

data/projects/all.json Show resolved Hide resolved
data/projects/all.json Show resolved Hide resolved
@eddie-knight eddie-knight merged commit fd6b076 into main Nov 15, 2024
3 checks passed
@eddie-knight eddie-knight deleted the projects/add-generated-clients branch November 15, 2024 12:29
@eddie-knight eddie-knight restored the projects/add-generated-clients branch November 15, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 😍 cla signed The CLA is signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants