fix: pop REACT_APP_GITHUB_CLIENT_ID into .env file

Signed-off-by: Paul Horton <phorton@sonatype.com>

.github/workflows/release.yml

@@ -30,12 +30,10 @@ jobs:
                   username: ${{ secrets.DOCKER_HUB_USERNAME }}
                   password: ${{ secrets.DOCKER_HUB_TOKEN }}
 
-            - name: Create .env file for Docker Build
-              run: echo "REACT_APP_GITHUB_CLIENT_ID=${{ secrets.REACT_APP_GITHUB_CLIENT_ID }} > .env"
-
             - name: Build and Publish
               uses: docker/build-push-action@v5
               with:
+                  build-args: 'REACT_APP_GITHUB_CLIENT_ID: ${{ secrets.REACT_APP_GITHUB_CLIENT_ID }}'
                   context: .
                   file: ./Dockerfile
                   platforms: linux/amd64

Dockerfile

@@ -15,6 +15,7 @@
 #
 
 FROM node:18-alpine3.18 as yarn-build
+ARG REACT_APP_GITHUB_CLIENT_ID=FAKE_ID
 LABEL stage=builder
 
 RUN apk add --no-cache build-base
@@ -23,7 +24,7 @@ WORKDIR /src
 
 COPY . .
 
-RUN make yarn
+RUN REACT_APP_GITHUB_CLIENT_ID=$REACT_APP_GITHUB_CLIENT_ID make yarn
 
 FROM golang:1.21-alpine AS build
 LABEL stage=builder