fix: add repo status failure call if commits fail quailty checks #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Horton <phorton@sonatype.com>
Signed-off-by: Paul Horton <phorton@sonatype.com>
bhamail
reviewed
Sep 18, 2024
| @@ -366,6 +368,11 @@ func EvaluatePullRequest(logger *zap.Logger, postgres db.IClaDB, evalInfo *types | |||
| return err | |||
| } | |||
|
|
|||
| err = createRepoStatus(client.Repositories, evalInfo.RepoOwner, evalInfo.RepoName, evalInfo.Sha, "failure", "One or more commits haven't met our Quality requirements.", botName) | |||
There was a problem hiding this comment.
I'm looking into trying to use the Mock objects to see if we can assert some state in unit tests for these sorts of things. It might complicate this PR a little, but should hopefully open the door to better unit tests and maybe allow refactoring some of these huge methods into smaller units. Spoiler: repositoriesMock yadda, yadda...
…mocks update mocks to assert multiple calls to mock functions
|
bhamail
deleted the
fix/update-repo-status-post-commit-quality-checks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #113