update mocks to assert multiple calls to mock functions #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhamail
changed the title
|
madpah
approved these changes
Sep 19, 2024
|
B-E-A-utiful. LGTM |
madpah
merged commit 6f3a6d6
into
fix/update-repo-status-post-commit-quality-checks
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our mocks to support multiple calls to mocked functions and validating each call individually. The idea is to allow optional assertions on the mock calls. If you do not find this too disgusting, feel free to merge it into PR #114.
My intent is to allow the mocks to better assert unit test conditions going forward.
(I'm totally fine with replacing all of this with a better mock library in the future.)