Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECN IXIA test for verifying equal marking due to traffic causing congestion #15849

Merged

Conversation

sreejithsreekumaran
Copy link
Contributor

@sreejithsreekumaran sreejithsreekumaran commented Dec 3, 2024

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Make the test case multi Topo capable.
Add ecn marking ratio check for flow percent where both

lossless TC are >= 50 to have equal marking

How did you do it?

Ixia testcase enhancement

How did you verify/test it?

On Ixia connected DUT

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Also added ecn marking ratio check for TC 3 and 4 traffic flow variations
@sreejithsreekumaran sreejithsreekumaran changed the title Ecn scripts t2 support ECN IXIA test for verifying equal marking due to traffic causing congestion Dec 3, 2024
@sreejithsreekumaran
Copy link
Contributor Author

@sdszhang FYI

@sdszhang
Copy link
Contributor

sdszhang commented Dec 4, 2024

@sreejithsreekumaran can you update the result for t2 and t0/t1?

@abdosi can you help to review? Thanks.

@sreejithsreekumaran
Copy link
Contributor Author

@sreejithsreekumaran can you update the result for t2 and t0/t1?

@abdosi can you help to review? Thanks.

From t0/t1

----------------------------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
------------------------------------------------------------------------------------------------------------------------------------ live log sessionfinish -------------------------------------------------------------------------------------------------------------------------------------
16:29:34 __init__.pytest_terminal_summary         L0067 INFO   | Can not get Allure report URL. Please check logs
==================================================================================================================================== short test summary info ====================================================================================================================================
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent0]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent1]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent2]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent3]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent4]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent5]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent6]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent7]
========================================================================================================================== 8 passed, 11 warnings in 942.58s (0:15:42) ===========================================================================================================================

From T2


INFO:root:Can not get Allure report URL. Please check logs
------------------------------------------------------------------------------------------------------------------------------------ live log sessionfinish -------------------------------------------------------------------------------------------------------------------------------------
15:50:12 __init__.pytest_terminal_summary         L0067 INFO   | Can not get Allure report URL. Please check logs
==================================================================================================================================== short test summary info ====================================================================================================================================
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent0]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent1]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent2]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent3]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent4]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent5]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent6]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_lossless_prio[multidut_port_info0-test_flow_percent7]
========================================================================================================================== 8 passed, 11 warnings in 1363.11s (0:22:43) ==========================================================================================================================

Copy link
Contributor

@sdszhang sdszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit a554d42 into sonic-net:master Dec 9, 2024
17 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Dec 9, 2024
…estion (sonic-net#15849)

Description of PR
Summary:
Fixes # (issue)

Approach
What is the motivation for this PR?
Make the test case multi Topo capable.
Add ecn marking ratio check for flow percent where both

lossless TC are >= 50 to have equal marking

How did you do it?
Ixia testcase enhancement

How did you verify/test it?
On Ixia connected DUT

co-authorized by: jianquanye@microsoft.com
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #15945

mssonicbld pushed a commit that referenced this pull request Dec 9, 2024
…estion (#15849)

Description of PR
Summary:
Fixes # (issue)

Approach
What is the motivation for this PR?
Make the test case multi Topo capable.
Add ecn marking ratio check for flow percent where both

lossless TC are >= 50 to have equal marking

How did you do it?
Ixia testcase enhancement

How did you verify/test it?
On Ixia connected DUT

co-authorized by: jianquanye@microsoft.com
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 2, 2025
…estion (sonic-net#15849)

Description of PR
Summary:
Fixes # (issue)

Approach
What is the motivation for this PR?
Make the test case multi Topo capable.
Add ecn marking ratio check for flow percent where both

lossless TC are >= 50 to have equal marking

How did you do it?
Ixia testcase enhancement

How did you verify/test it?
On Ixia connected DUT

co-authorized by: jianquanye@microsoft.com
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16281

mssonicbld pushed a commit that referenced this pull request Jan 2, 2025
…estion (#15849)

Description of PR
Summary:
Fixes # (issue)

Approach
What is the motivation for this PR?
Make the test case multi Topo capable.
Add ecn marking ratio check for flow percent where both

lossless TC are >= 50 to have equal marking

How did you do it?
Ixia testcase enhancement

How did you verify/test it?
On Ixia connected DUT

co-authorized by: jianquanye@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants