[snmp]Skipping enable_queue_counterpoll_type fixture for Nokia 7215 armhf platforms #16019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Blueve
approved these changes
Dec 25, 2024
lizhijianrd
approved these changes
Dec 25, 2024
Blueve
reviewed
Dec 25, 2024
| @@ -95,7 +95,8 @@ def check_redis_output(duthost, key): | |||
| @pytest.fixture(scope="module", autouse=True) | |||
| def enable_queue_counterpoll_type(duthosts): | |||
There was a problem hiding this comment.
This fixture might not good to be set to autouse. @lizhijianrd please create an issue, we need clean up this later.
wangxin
approved these changes
Dec 26, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 26, 2024
…onic-net#16019) What is the motivation for this PR? Fixture enable_queue_counterpoll_type in snmp is enabling queue counterpolls. But for Nokia 7215 armhf platforms, as queue statistics are not supported, there is an error while executing this command : "SAI_OBJECT_TYPE_QUEUE is not Supported". So, added a skip condition inside the fixture for Nokia 7215 armhf platforms How did you do it? Added condition inside fixture to skip for Nokia 7215 armhf platform How did you verify/test it? Run snmp test suite and verify fixture is not executed on Nokia-7215 armhf platforms
|
Cherry-pick PR to 202411: #16236 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 26, 2024
…onic-net#16019) What is the motivation for this PR? Fixture enable_queue_counterpoll_type in snmp is enabling queue counterpolls. But for Nokia 7215 armhf platforms, as queue statistics are not supported, there is an error while executing this command : "SAI_OBJECT_TYPE_QUEUE is not Supported". So, added a skip condition inside the fixture for Nokia 7215 armhf platforms How did you do it? Added condition inside fixture to skip for Nokia 7215 armhf platform How did you verify/test it? Run snmp test suite and verify fixture is not executed on Nokia-7215 armhf platforms
|
Cherry-pick PR to 202405: #16237 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 26, 2024
…16019) What is the motivation for this PR? Fixture enable_queue_counterpoll_type in snmp is enabling queue counterpolls. But for Nokia 7215 armhf platforms, as queue statistics are not supported, there is an error while executing this command : "SAI_OBJECT_TYPE_QUEUE is not Supported". So, added a skip condition inside the fixture for Nokia 7215 armhf platforms How did you do it? Added condition inside fixture to skip for Nokia 7215 armhf platform How did you verify/test it? Run snmp test suite and verify fixture is not executed on Nokia-7215 armhf platforms
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixture enable_queue_counterpoll_type in snmp is enabling queue counterpolls. But for Nokia 7215 armhf platforms, as queue statistics are not supported, there is an error while executing this command : "SAI_OBJECT_TYPE_QUEUE is not Supported".
So, added a skip condition inside the fixture for Nokia 7215 armhf platforms
Summary:
Fixes error: "SAI_OBJECT_TYPE_QUEUE is not Supported" in Nokia 7215 armhf platforms
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
Added condition inside fixture to skip for Nokia 7215 armhf platform
How did you verify/test it?
Run snmp test suite and verify fixture is not executed on Nokia-7215 armhf platforms
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation