T2/snappi: Use natsort instead of sort for sorting the asic list in disable_pfcwd and enable_pfcwd functions. #16176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and enable_pfcwd functions.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zhixzhu
approved these changes
Dec 20, 2024
auspham
approved these changes
Dec 21, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 1, 2025
…d and enable_pfcwd functions. (sonic-net#16176) Description of PR Summary: Even after sonic-net#15863, the problem is still seen in RP. The issue is that the sort() function only sorts alphabetically, not numerically. So we need to use natsort module instead of normal sort() in these functions. Approach What is the motivation for this PR? Seeing a lot of loganalyzer messages, but in RP only. How did you do it? Change sort to natsort(). How did you verify/test it? Running in my TB, I don't see the LA error anymore. Any platform specific information? T2 mAsic only. co-authorized by: jianquanye@microsoft.com
|
Cherry-pick PR to 202411: #16276 |
9 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 2, 2025
…d and enable_pfcwd functions. (#16176) Description of PR Summary: Even after #15863, the problem is still seen in RP. The issue is that the sort() function only sorts alphabetically, not numerically. So we need to use natsort module instead of normal sort() in these functions. Approach What is the motivation for this PR? Seeing a lot of loganalyzer messages, but in RP only. How did you do it? Change sort to natsort(). How did you verify/test it? Running in my TB, I don't see the LA error anymore. Any platform specific information? T2 mAsic only. co-authorized by: jianquanye@microsoft.com
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
|
Chassis output: T0/T1 testbed are being used for other purpose, not able to verify it on T0/T1. As T0/T1 is using single ASIC, this change should not affect them. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 2, 2025
…d and enable_pfcwd functions. (sonic-net#16176) Description of PR Summary: Even after sonic-net#15863, the problem is still seen in RP. The issue is that the sort() function only sorts alphabetically, not numerically. So we need to use natsort module instead of normal sort() in these functions. Approach What is the motivation for this PR? Seeing a lot of loganalyzer messages, but in RP only. How did you do it? Change sort to natsort(). How did you verify/test it? Running in my TB, I don't see the LA error anymore. Any platform specific information? T2 mAsic only. co-authorized by: jianquanye@microsoft.com
|
Cherry-pick PR to 202405: #16291 |
9 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 2, 2025
…d and enable_pfcwd functions. (#16176) Description of PR Summary: Even after #15863, the problem is still seen in RP. The issue is that the sort() function only sorts alphabetically, not numerically. So we need to use natsort module instead of normal sort() in these functions. Approach What is the motivation for this PR? Seeing a lot of loganalyzer messages, but in RP only. How did you do it? Change sort to natsort(). How did you verify/test it? Running in my TB, I don't see the LA error anymore. Any platform specific information? T2 mAsic only. co-authorized by: jianquanye@microsoft.com
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Even after #15863, the problem is still seen in RP. The issue is that the sort() function only sorts alphabetically, not numerically. So we need to use natsort module instead of normal sort() in these functions.
Type of change
Back port request
Approach
What is the motivation for this PR?
Seeing a lot of loganalyzer messages, but in RP only.
How did you do it?
Change sort to natsort().
How did you verify/test it?
Running in my TB, I don't see the LA error anymore.
Any platform specific information?
T2 mAsic only.