Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Thermal Test Cases for Threshold Settings #16243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PJHsieh
Copy link
Contributor

@PJHsieh PJHsieh commented Dec 26, 2024

Description of PR

Updated the thermal test cases to handle high and low temperature threshold configurations effectively.

  • Predefined default values for high and low threshold temperatures.
  • The high threshold test now attempts to set the threshold to 80°C. If the current high threshold is below 80°C, the test may fail as increasing the threshold might not be allowed.
  • Similarly, the low threshold test has been adjusted to account for system constraints when setting a lower threshold.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Refactor Thermal Test Cases for Threshold Settings

How did you do it?

Updated the thermal test cases to handle high and low temperature threshold configurations effectively.

How did you verify/test it?

Retrieve the current high threshold. If it is less than 80°C, set the high threshold to current_high_threshold - 1 for testing.
Retrieve the current low threshold. If it is greater than 20°C, set the low threshold to current_low_threshold + 1 for testing.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Updated the thermal test cases to handle high and low temperature threshold configurations effectively.

* Predefined default values for high and low threshold temperatures.
* The high threshold test now attempts to set the threshold to 80°C. If the current high threshold is
  below 80°C, the test may fail as increasing the threshold might not be allowed.
* Similarly, the low threshold test has been adjusted to account for system constraints when setting a
  lower threshold.
@PJHsieh PJHsieh requested a review from prgeor as a code owner December 26, 2024 08:08
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PJHsieh
Copy link
Contributor Author

PJHsieh commented Dec 27, 2024

Hi, @prgeor ,

all checks have passed. Please review and merge this PR, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants