[action] [PR:15972] Update tests to handle PSUs with multiple PDUs #16319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple PDUs (sonic-net#15972) Description of PR Summary: Update test_turn_off_psu_and_check_psu_info to ensure that it handles PSUs with multilpe PDUs correctly Update test_turn_on_off_psu_and_check_psustatus to handle PSUs with multiple PDUs correctly Approach Instead of toggling one outlet/PDU, toggle a full set of PDUs connected to one PSU Move common PSU helpers function to new psu_helpers.py in tests/common/helpers folder Add try / catch block to ensure all PSUs are turned back on after the test What is the motivation for this PR? Prevent test from failing when toggling a PDU connected to a PSU that will stay on due to other redundant PDUs that were not toggled. How did you do it? Break PDUs into sets based on PSU, make sure to toggle whole sets at once. How did you verify/test it? https://elastictest.org/scheduler/testplan/675919214fa1c38a7e20b96c <- T0/T1 regression test Tested on T2 testbed as well (bar known issues with certain testbed types) Signed-off-by: Javier Tan javiertan@microsoft.com
|
/azp run |
8 tasks
|
Original PR: #15972 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Update test_turn_off_psu_and_check_psu_info to ensure that it handles PSUs with multilpe PDUs correctly
Update test_turn_on_off_psu_and_check_psustatus to handle PSUs with multiple PDUs correctly
Type of change
Back port request
Approach
What is the motivation for this PR?
Prevent test from failing when toggling a PDU connected to a PSU that will stay on due to other redundant PDUs that were not toggled.
How did you do it?
Break PDUs into sets based on PSU, make sure to toggle whole sets at once.
How did you verify/test it?
https://elastictest.org/scheduler/testplan/675919214fa1c38a7e20b96c <- T0/T1 regression test
Tested on T2 testbed as well (bar known issues with certain testbed types)
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A