Add FEC correctable bit error count to ports_stat_ids #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prince George <prgeor@microsoft.com>
prgeor
requested review from
prsunny and
eddyk-nvidia
and removed request for
prsunny
|
@prsunny @eddyk-nvidia could you please review? |
dgsudharsan
approved these changes
Sep 18, 2024
eddyk-nvidia
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added additional SAI counter to port_stats_id
SAI_PORT_STAT_IF_IN_FEC_CORRECTED_BITS
Why I did it
This state needs to be polled to estimate pre-FEC BER
How I verified it
This will be verified once SAI/SDK supports this new counter.
Details if related