Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default behavior of show ip bgp network (#3447) #86

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Change the default behavior of show ip bgp network (#3447) #86

merged 1 commit into from
Jul 31, 2024

Conversation

gechiang
Copy link
Collaborator

  • show/bgp_frr_v4.py: change the default behavior of "show ip bgp network"
  • after change, show ip bgp network will have "all" as the default value of namespace option
  • after change, ip-address/ip-prefix is a required argument when executing show ip bgp network on a chassis supervisor
  • tests/remote_show_test.py update unit tests to comply with the new behaviors

  • tests/show_bgp_network_test.py: update a test vector to make it comply with the new default behavior

  • tests/bgp_commands_input/bgp_network_test_vector.py: update a test vector to comply with the new default behavior

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

* show/bgp_frr_v4.py: change the default behavior of "show ip bgp network"

- after change, show ip bgp network will have "all" as the default value of namespace option
- after change, ip-address/ip-prefix is a required argument when executing show ip bgp network on a chassis supervisor

* tests/remote_show_test.py update unit tests to comply with the new behaviors

* tests/show_bgp_network_test.py: update a test vector to make it comply with the new default behavior

* tests/bgp_commands_input/bgp_network_test_vector.py: update a test vector to comply with the new default behavior
@gechiang gechiang requested a review from BYGX-wcr July 31, 2024 19:18
Copy link
Collaborator

@BYGX-wcr BYGX-wcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@gechiang gechiang merged commit 2578ea4 into sonic-net:202205 Jul 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants