Need to add check for local_addr in get_bgp_peer #19930
Comments
11 tasks
|
@eddieruan-alibaba not sure what is the ask here. it seems that this was opened as part of another PR review? |
|
Need someone to put the fix in show ip interface command. The diff suggested by @venkatmahalingam is not related to my existing. It is an existing issue which needs to be fixed. |
|
@StormLiangMS , can you help take a look at this one and see if this is something requiring some work and help assign accordingly? |
|
Find fix here sonic-net/sonic-utilities#3565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
https://github.com/sonic-net/sonic-utilities/blob/317e649514c9b205849ffb5ea96a6a233e38290c/scripts/ipintutil#L51
In get_bgp_peer(), local_addr is picked mandatory. But local_addr maps to update source config in BGP which is not a mandatory config for a BGP neighbor config.
During #19924 review, @venkatmahalingam suggests to make the change as
if 'local_addr' in data[neighbor_ip]:
local_addr = data[neighbor_ip]['local_addr']
else:
local_addr = ""
Open this issue to track the change.
Steps to reproduce the issue:
Describe the results you received:
Describe the results you expected:
Output of
show version:Output of
show techsupport:Additional information you deem important (e.g. issue happens only occasionally):
The text was updated successfully, but these errors were encountered: