Extra delay between running firmware and updating firmware version #3610
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Sun <stephens@nvidia.com>
mihirpat1
reviewed
Nov 12, 2024
| @@ -1607,6 +1608,9 @@ def run(port_name, mode): | |||
| click.echo('Failed to run firmware in mode={}! CDB status: {}'.format(mode, status)) | |||
| sys.exit(EXIT_FAIL) | |||
|
|
|||
| if delay: | |||
There was a problem hiding this comment.
@stephenxs Can you put a comment why this delay is required?
| @@ -1591,6 +1591,7 @@ def download_firmware(port_name, filepath): | |||
| 1 = Hitless Reset to Inactive Image (Default)\n \ | |||
| 2 = Attempt non-hitless Reset to Running Image\n \ | |||
| 3 = Attempt Hitless Reset to Running Image\n") | |||
| @click.option('--delay', metavar='<delay>', type=click.IntRange(0, 10), help="Delay time before updating firmware information to STATE_DB") | |||
There was a problem hiding this comment.
@prgeor Should we have a default delay of 5s for all modules?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Introduce a delay in "sfputil firmware run" between running firmware and updating the cable firmware version info.
The flow of "sfputil firmware run" is the following
It takes time for the cable to get ready after switching firmware, which can cause an error message in step 2.
We introduce a CLI option to specify a delay between step 1 and 2 to avoid error message.
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)