Remove partially installer image when image install failed. #3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Jan 16, 2025
sonic_installer/main.py
Outdated
| echo_and_log('Delete partial installed image: {}'.format(binary_image_version)) | ||
| new_image_dir = bootloader.get_image_path(binary_image_version) | ||
| run_command(["rm", "-rf", new_image_dir]) | ||
| raise e |
qiluo-msft
reviewed
Jan 16, 2025
| echo_and_log('Image install failed with exception: {}'.format(e)) | ||
| echo_and_log('Delete partial installed image: {}'.format(binary_image_version)) | ||
| new_image_dir = bootloader.get_image_path(binary_image_version) | ||
| run_command(["rm", "-rf", new_image_dir]) |
There was a problem hiding this comment.
Should we use bootloader.remove_image ?
There was a problem hiding this comment.
We can't because remove_image need check bootloader info, but install failed at here doesn't update bootloader.
The bootloader will be update by line 612:
update_sonic_environment(bootloader, binary_image_version)
A partial installed image failed here only extract files to /host/image-version folder, so we only need to delete that folder.
There was a problem hiding this comment.
how about shutil.rmtree ?
qiluo-msft
reviewed
Jan 16, 2025
sonic_installer/main.py
Outdated
| bootloader.install_image(image_path) | ||
| try: | ||
| bootloader.install_image(image_path) | ||
| except BaseException as e: |
There was a problem hiding this comment.
Fixed, install image failed with throw SystemExit exception.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove partially installer image when image install failed.
What I did
When install image failed, partially installed image not removed, which may cause disk full issue on small disk device.
How I did it
Handle install image SystemExit exception and uninstall image.
How to verify it
Manually verify.
Pass all test case
Work item tracking
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)