[FEAT] S3Service에 ExternalException 적용

sopt-makers · Dec 23, 2024 · b41ad7a · b41ad7a
1 parent b119b61
commit b41ad7a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...tion-common/src/main/java/org/sopt/makers/operation/code/failure/ExternalFailureCode.java b/...tion-common/src/main/java/org/sopt/makers/operation/code/failure/ExternalFailureCode.java
@@ -8,7 +8,7 @@
 @RequiredArgsConstructor
 @Getter
 public enum ExternalFailureCode implements FailureCode {
-    FAIL_FOUND_S3_RESOURCE(NOT_FOUND, "S3에서 객체를 찾지 못했습니다");
+    NOT_FOUND_S3_RESOURCE(NOT_FOUND, "S3에서 객체를 찾지 못했습니다");
 
     private final HttpStatus status;
     private final String message;

diff --git a/operation-external/src/main/java/org/sopt/makers/operation/client/s3/S3ServiceImpl.java b/operation-external/src/main/java/org/sopt/makers/operation/client/s3/S3ServiceImpl.java
@@ -1,6 +1,6 @@
 package org.sopt.makers.operation.client.s3;
 
-import static org.sopt.makers.operation.code.failure.BannerFailureCode.NOT_FOUND_BANNER_IMAGE;
+import static org.sopt.makers.operation.code.failure.ExternalFailureCode.NOT_FOUND_S3_RESOURCE;
 
 import java.time.Duration;
 
@@ -42,7 +42,7 @@ public String getUrl(String bucketName, String fileName) {
         try {
             return s3Client.utilities().getUrl(b -> b.bucket(bucketName).key(fileName)).toExternalForm();
         } catch(NoSuchKeyException e) {
-            throw new BannerException(NOT_FOUND_BANNER_IMAGE);
+            throw new ExternalException(NOT_FOUND_S3_RESOURCE);
         }
     }