Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] react hook form register naming 통일 #177

Merged
merged 7 commits into from
Dec 30, 2024

Conversation

eonseok-jeon
Copy link
Member

@eonseok-jeon eonseok-jeon commented Dec 23, 2024

✨ 구현 기능 명세

✅ PR Point

register 이름이 제 각각이라 관리하기 힘들더라고요
승희가 한 방식대로 객체로 관리하면 코드 중복도 많이 줄일 수 있을 거 같아 동일하게 처리해 줬어요

데이터 정상적으로 들어오는지와 에러 처리 잘 되는지만 체크 했어요
다른 기능들(e.g. Chip 모든 항목 required 처리 등)은 고려하지 않았습니다
코리할 때도 그 부분들만 보시면 될 거 같아요

변경한 부분
공통 탭 - 모집 일정, 브랜딩 컬러
지원하기 탭 - 파트별 소개, 자주 묻는 질문

데이터는 정상적으로 들어오는 걸 확인할 수 있었어요
스크린샷 2024-12-23 오후 8 39 19
스크린샷 2024-12-23 오후 9 33 49

입력 안 했을 때 에러 처리도 정상적으로 되고 있습니다
스크린샷 2024-12-23 오후 8 41 37

추후 해야할 것들

  • type any 제거하기
  • 모집 일정 OB/YB 와 같이 Chip을 이용하는 경우, 빈 값들 있을 때 해당 섹션 에러 처리 + focus 되기

@eonseok-jeon eonseok-jeon self-assigned this Dec 23, 2024
@eonseok-jeon eonseok-jeon linked an issue Dec 23, 2024 that may be closed by this pull request
Copy link

height bot commented Dec 23, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

cloudflare-workers-and-pages bot commented Dec 23, 2024

Deploying sopt-admin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 28e1cb1
Status: ✅  Deploy successful!
Preview URL: https://0da6e4b1.sopt-admin.pages.dev
Branch Preview URL: https://refactor-org-register-naming.sopt-admin.pages.dev

View logs

@eonseok-jeon eonseok-jeon force-pushed the refactor-org-register-naming branch from ef36cf6 to 28e1cb1 Compare December 23, 2024 14:26
Copy link
Member

@lydiacho lydiacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 좋습니다!! 감사합니다 🙇🏻‍♀️🙇🏻‍♀️🚀

@eonseok-jeon eonseok-jeon merged commit ad5c731 into dev Dec 30, 2024
1 check passed
@eonseok-jeon eonseok-jeon deleted the refactor-org-register-naming branch January 12, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] react hook form register naming 통일
2 participants