-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] org admin 빈 곳 있을 시 해당 섹션으로 이동 #179
Open
eonseok-jeon
wants to merge
10
commits into
refactor-org-register-naming
Choose a base branch
from
feature-org-common-fill-yb
base: refactor-org-register-naming
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[FEATURE] org admin 빈 곳 있을 시 해당 섹션으로 이동 #179
eonseok-jeon
wants to merge
10
commits into
refactor-org-register-naming
from
feature-org-common-fill-yb
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploying sopt-admin with Cloudflare Pages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR Point
더 효율적인 방법이 없을까 고민을 많이 했는데 찾지 못했어요
일일이 다 값 비교해보고 빈 값 있으면 해당 섹션으로 이동하게 했어요
홈 탭은 아직 주용이 pr 머지 안 되어서 일단 그대로 뒀어요
일단 현재 페이지에 빈 곳이 있는지 없는지 체크를 먼저하게 했어요
특히 Chip을 이용하는 곳은 빈 곳이 있을 경우 해당 Chip이 선택 되도록 했어요
여러 곳이 비어있다면 그 중 제일 첫 번째 input만 error 처리 되도록 했어요
다 채워져 있다면 공통 -> 홈 -> 소개 -> 지원하기 탭 순으로 체크하게 했습니다
추가로 빈 필드가 있을 시 error toast가 뜨도록 구현했어요
앞으로 해야할 것