Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAUTRE] 공홈 어드민 공통 탭 hook form 연결 #149

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

lydiacho
Copy link
Member

@lydiacho lydiacho commented Nov 27, 2024

✨ 구현 기능 명세

✅ PR Point

  • 앞선 PR에서 말씀드린 것처럼 form label flatten 작업 동일하게 해주었습니다
  • colorPicker과 date input 쪽에서 hook form을 활용해서 조건부 스타일링 / 조건부 렌더링되도록 로직 반영했습니다
  • OB/YB 칩 선택 시 컴포넌트가 새로이 렌더링되지 않아 key prop 추가하기 위해 div wrapper 추가해주었습니다

@lydiacho lydiacho self-assigned this Nov 27, 2024
Copy link

height bot commented Nov 27, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

Deploying sopt-admin with  Cloudflare Pages  Cloudflare Pages

Latest commit: e8a2206
Status: ✅  Deploy successful!
Preview URL: https://62707fd9.sopt-admin.pages.dev
Branch Preview URL: https://feature-org-common-form.sopt-admin.pages.dev

View logs

Copy link
Member

@eonseok-jeon eonseok-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니디ㅏ :)

@eonseok-jeon eonseok-jeon merged commit 69cc330 into dev Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 공통 탭 react hook form 연결
2 participants