Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] 지원하기 탭 hook-form 고도화 #156

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

eonseok-jeon
Copy link
Member

@eonseok-jeon eonseok-jeon commented Nov 28, 2024

✅ PR Point

  • 제출 시 에러 메세지 안 사라지는 에러 해결
  • 파트별 소개, FNA 다 선택해야 폼 제출되도록 수정
  • 반복되는 로직 제거
  • 지원하기 탭 모든 값 입력 시 데이터 정상적으로 전송 확인

스크린샷 2024-11-28 오후 3 16 58

@eonseok-jeon eonseok-jeon self-assigned this Nov 28, 2024
Copy link

height bot commented Nov 28, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

cloudflare-workers-and-pages bot commented Nov 28, 2024

Deploying sopt-admin with  Cloudflare Pages  Cloudflare Pages

Latest commit: dca389b
Status: ✅  Deploy successful!
Preview URL: https://2b72333d.sopt-admin.pages.dev
Branch Preview URL: https://feature-org-recruit-hook-for.sopt-admin.pages.dev

View logs

@eonseok-jeon eonseok-jeon linked an issue Nov 28, 2024 that may be closed by this pull request
Copy link
Member

@lydiacho lydiacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컴포넌트 단일화하니까 훨씬 유지보수하기 좋아졌네용
수고하셨습니다!

@eonseok-jeon eonseok-jeon changed the base branch from feature-org-hook-form-upgrade to dev November 28, 2024 09:25
@eonseok-jeon eonseok-jeon merged commit bb86fbd into dev Nov 28, 2024
1 check passed
@eonseok-jeon eonseok-jeon deleted the feature-org-recruit-hook-form-upgrade branch November 28, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 지원하기 탭 hook-form 고도화
2 participants