Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement login caching for Chrome #85

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

zazer0
Copy link
Contributor

@zazer0 zazer0 commented Sep 11, 2024

Just added a flag to the tool's args, and passed it through to the Selenium ChromeDriver :)

Saves browser data - including cookies, which have the login - to the current directory (following naming convention of _default_out_Path).

@zazer0
Copy link
Contributor Author

zazer0 commented Sep 11, 2024

This should close #82 !

Signed-off-by: Tin Lai <tin@tinyiu.com>
Signed-off-by: Tin Lai <tin@tinyiu.com>
Signed-off-by: Tin Lai <tin@tinyiu.com>
Signed-off-by: Tin Lai <tin@tinyiu.com>
@soraxas
Copy link
Owner

soraxas commented Sep 16, 2024

Thanks @zazer0!

I've clarified the usage a bit and renamed the flag as --persistent-session / -P as that's what it's actually doing. Overall seems good!

@soraxas soraxas merged commit 4aee542 into soraxas:master Sep 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants