New modification statements #1161
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I found some places that potentially need to be updated if the new types are integrated: |
cthoyt
reviewed
Sep 15, 2020
indra/statements/statements.py
Outdated
| @@ -1005,6 +1020,66 @@ class Demethylation(RemoveModification): | |||
| """Demethylation modification.""" | |||
|
|
|||
|
|
|||
| class Carboxylation(AddModification): | |||
| """Carboxylation modification.""" | |||
| pass | |||
There was a problem hiding this comment.
if you have a docstring, you actually don't need a pass
|
Maybe it makes sense to add a bit of metadata along with each statement type to align them with related entries in other controlled vocabularies. For example, neddylation corresponds to the GO biological process "protein neddylation" (GO:0045116). I did this for PyBEL and you could copy relevant parts if you think this is a good idea. No single controlled vocabulary is covering all types of modifications, though. See: https://github.com/pybel/pybel/blob/57b24a9ddf6d5d73d82c92294ed2186ddf4443c5/src/pybel/language.py#L320-L524 |
kkaris
force-pushed
the
new-mod-stmts
branch
from
344d549 to
f500a34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new Modification statement types: