Merge pull request #238 from shkuviak/fix/director_base_path

Fixed director readiness probe failing whend using BASE_PATH env
sorry-cypress · Oct 13, 2023 · cdc2dfc · cdc2dfc
2 parents e4673f1 + 45e4c3e
commit cdc2dfc
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/charts/sorry-cypress/Chart.yaml b/charts/sorry-cypress/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: sorry-cypress
 description: A Helm chart for Sorry Cypress
 type: application
-version: 1.19.0
+version: 1.19.1
 appVersion: 2.5.10
 home: https://sorry-cypress.dev/
 sources:

diff --git a/charts/sorry-cypress/changelog.md b/charts/sorry-cypress/changelog.md
@@ -1,3 +1,6 @@
+# 1.19.1
+- Fixed director readiness probe failing when using BASE_PATH env
+
 # 1.19
 - Update app to version `2.5.10`
 

diff --git a/charts/sorry-cypress/templates/deployment-director.yml b/charts/sorry-cypress/templates/deployment-director.yml
@@ -161,6 +161,8 @@ spec:
           value: {{ .Values.director.environmentVariables.inactivityTimeoutSeconds | quote }}
         - name: GITLAB_JOB_RETRIES
           value: {{ .Values.director.environmentVariables.gitlabJobRetries | quote }}
+        - name: BASE_PATH
+          value: {{ .Values.director.environmentVariables.basePath | quote }}
         {{- with .Values.director.extraEnv }}
         {{- toYaml . | nindent 8 }}
         {{- end }}
@@ -175,7 +177,7 @@ spec:
           {{- toYaml .Values.director.securityContext | nindent 10 }}
         readinessProbe:
           httpGet:
-            path: /health-check-db
+            path: {{ .Values.director.environmentVariables.basePath }}/health-check-db
             port: 1234
           periodSeconds: {{ .Values.director.readinessProbe.periodSeconds }}
           timeoutSeconds: {{ .Values.director.readinessProbe.timeoutSeconds }}

diff --git a/charts/sorry-cypress/values.yaml b/charts/sorry-cypress/values.yaml
@@ -300,6 +300,9 @@ director:
     # Enable gitlab job retries
     gitlabJobRetries: false
 
+    # BASE_PATH serving path, usefull when using reverse proxy ex: /cypress/dashboard
+    basePath: ""
+
   # Set annotations for pods
   podAnnotations: {}