Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentibiabr revscriptsys][output] Add support for this format #45

Open
soul4soul opened this issue Sep 3, 2021 · 0 comments
Open

[opentibiabr revscriptsys][output] Add support for this format #45

soul4soul opened this issue Sep 3, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@soul4soul
Copy link
Owner

soul4soul commented Sep 3, 2021

https://github.com/opentibiabr/canary has used this tool in the past, it was used to aid in convertering the creatures in their repo from XML to revscriptsys. They used a fork of the v2.0~ release which had many issues. Since then the program has under gone extensive changes which would make rebasing difficult.

Support for this format can be added with minimal effort since it's a derivative of the tfs revscriptsys format.

Tech implementation:
Not sure how I want to handle it yet, so far all converters have been in separate binaries. Due to the similarity with tfs revscriptsys format I'm thinking of adding it to the same binary. The current class can be changed to an abstract base class, which tfs and otserverbr classes can inherit. The base class can accept an enum to indicate TFS or otserv and have conditional checks as necessary. Instead of passing a enum to the baseclass the giant function to output the lua file can be split up into sub functions for general info, attacks, defensives, loot, immunities, etc.. and the inherited classes can override those when there are differences.

@soul4soul soul4soul added the enhancement New feature or request label Sep 3, 2021
@soul4soul soul4soul changed the title [otservbr revscriptsys][output] Add support for this format [opentibiabr revscriptsys][output] Add support for this format Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant