Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark-mode feature #26

Closed

Conversation

codingninja11
Copy link

@codingninja11 codingninja11 commented Jul 5, 2021

closes #14

React.App.-.Google.Chrome.2021-07-05.17-17-24.mp4

@soumik2012

@vercel
Copy link

vercel bot commented Jul 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/soumik2012/chathub/3cBUpeH7ehG7G5Pbfzzn9qFHDQWP
✅ Preview: Failed

@@ -1,5 +1,5 @@
import './App.css';
import React from 'react';
import React, { useState, useEffect } from 'react';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this use Effect and use state

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

On the login page we clicking on the dark mode button it is not changing the dark color or please change the size of the button to normal.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Add the dark button in here. or please remove all the errors and warnings then make the PR @codingninja11

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If are done, then feel free to Re-request review

Copy link
Author

@codingninja11 codingninja11 Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this use Effect and use state

why it should be removed?please explain!
@soumik2012

Copy link
Author

@codingninja11 codingninja11 Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Add the dark button in here. or please remove all the errors and warnings then make the PR @codingninja11

There are no errors when I'm running it on my device and for adding the functionality here please guide me how can I implement the same thing here.
@soumik2012

Copy link
Owner

@soumikbaithalu soumikbaithalu Jul 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this use Effect and use state

why it should be removed?please explain!
@soumik2012

image
see this error also it's not deploying it giving the fail
image

@soumikbaithalu
Copy link
Owner

Closing the issue due to no response Thank you for making the PR you can check other issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DarkTheme and Light Theme feature for the App
2 participants