-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dark-mode feature #26
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/soumik2012/chathub/3cBUpeH7ehG7G5Pbfzzn9qFHDQWP |
@@ -1,5 +1,5 @@ | |||
import './App.css'; | |||
import React from 'react'; | |||
import React, { useState, useEffect } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this use Effect and use state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the dark button in here. or please remove all the errors and warnings then make the PR @codingninja11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If are done, then feel free to Re-request review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this use Effect and use state
why it should be removed?please explain!
@soumik2012
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the dark button in here. or please remove all the errors and warnings then make the PR @codingninja11
There are no errors when I'm running it on my device and for adding the functionality here please guide me how can I implement the same thing here.
@soumik2012
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing the issue due to no response Thank you for making the PR you can check other issue |
closes #14
React.App.-.Google.Chrome.2021-07-05.17-17-24.mp4
@soumik2012