Skip to content

Commit

Permalink
Cleanup Leftover Regex
Browse files Browse the repository at this point in the history 
Also don't take inputs as string literals if we don't know their value yet.
  • Loading branch information
@sounddrill31
sounddrill31 authored Jul 25, 2024
1 parent 88b9505 commit 7c2b384
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ jobs:
;;
esac
if [[ "${{ github.event.inputs.PRODUCT_NAME }}" == *_*/* ]] && [[ "${{ github.event.inputs.PRODUCT_NAME }}" != gsi_* ]] && [[ "${{ github.event.inputs.PRODUCT_NAME }}" != sdk_* ]]; then
if [[ ${{ github.event.inputs.PRODUCT_NAME }} == *_* ]] && [[ ${{ github.event.inputs.PRODUCT_NAME }} != gsi_* ]] && [[ ${{ github.event.inputs.PRODUCT_NAME }} != sdk_* ]]; then
LUNCH="lunch ${{ github.event.inputs.PRODUCT_NAME }}-${{ github.event.inputs.BUILD_TYPE }}"
elif [[ "${{ github.event.inputs.BASE_PROJECT }}" == "RisingOS 14" ]] && [[ "${{ github.event.inputs.BUILD_DIFFERENT_ROM }}" == "echo 'Build Starting!'" ]]; then
LUNCH="riseup ${{ github.event.inputs.PRODUCT_NAME }} ${{ github.event.inputs.BUILD_TYPE }}"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/selfhosted.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ jobs:
;;
esac
if [[ "${{ github.event.inputs.PRODUCT_NAME }}" == *_*/* ]] && [[ "${{ github.event.inputs.PRODUCT_NAME }}" != gsi_* ]] && [[ "${{ github.event.inputs.PRODUCT_NAME }}" != sdk_* ]]; then
if [[ ${{ github.event.inputs.PRODUCT_NAME }} == *_* ]] && [[ ${{ github.event.inputs.PRODUCT_NAME }} != gsi_* ]] && [[ ${{ github.event.inputs.PRODUCT_NAME }} != sdk_* ]]; then
LUNCH="lunch ${{ github.event.inputs.PRODUCT_NAME }}-${{ github.event.inputs.BUILD_TYPE }}"
elif [[ "${{ github.event.inputs.BASE_PROJECT }}" == "RisingOS 14" ]] && [[ "${{ github.event.inputs.BUILD_DIFFERENT_ROM }}" == "echo 'Build Starting!'" ]]; then
LUNCH="riseup ${{ github.event.inputs.PRODUCT_NAME }} ${{ github.event.inputs.BUILD_TYPE }}"
Expand Down

0 comments on commit 7c2b384

Please sign in to comment.