java 17 & boot #64
Merged
java 17 & boot #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehoehns
commented
Oct 14, 2023
| @@ -2,6 +2,9 @@ | |||
| "name": "Mono", | |||
| "image": "mcr.microsoft.com/devcontainers/universal:focal", | |||
| "postAttachCommand": "source ./init.sh", | |||
| "containerEnv": { | |||
There was a problem hiding this comment.
This is the magic that defaults us to using 17 instead of 11 🤦
There was a problem hiding this comment.
in what world would I ever think that DISABLE_JAVA_BUILD => Java 17 wild
kylehoehns
force-pushed
the
spring-boot
branch
from
f58d8bc
to
22e8153
Compare
nbatterson
approved these changes
Oct 14, 2023
tim-hornback-SAI
approved these changes
Oct 14, 2023
tim-hornback-SAI
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.