Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFTP support #232

Merged
merged 27 commits into from
Oct 18, 2024
Merged

SFTP support #232

merged 27 commits into from
Oct 18, 2024

Conversation

sourcefrog
Copy link
Owner

@sourcefrog sourcefrog commented Dec 3, 2023 •
edited
Loading

SFTP transport to archives

Uses Rust ssh2 crate

TODO

  • Make sftp a conditional feature
  • Default username, the same as the local username?
  • Mention in the docs
  • Doc that only agents are supported for auth, or support more auth methods

Later

  • Integration test that either needs real SSH creds, or that sets up an SSH server. (Might be a bit of work.)

Fixes #83

@sourcefrog
Basic readonly sftp
968663b
@sourcefrog
Use tracing for sftp debug info
4f93f1f
@sourcefrog
Better todo messages
6d46265
@sourcefrog
Try for better SSH error reporting
3951fd2
@sourcefrog
Clear RUST_LOG when running test subprocesses
aa4fcda 
Previously, the ambient setting caused tests to fail due to writing to
their captured stdout.
@sourcefrog
SFTPTransport::lstat error handling
f834832
@sourcefrog
Sftp object does not need external locks
2626b18
@sourcefrog
sftp create_dir and write_file
2284013 
Enough to do basic backups!
@sourcefrog
Use pushed ssh2-rs to avoid short readdir buffer problem
ec4f1e4
@sourcefrog
Add SftpTransport::metadata
3b021cf 
Use the default impl for is_dir and is_file
@sourcefrog
Stop iterating index hunks after first reaching the end
9a0a5f1 
Fixes a hard-to-reproduce bug where a backup over SFTP with an
interrupted basis seems to get stuck in a loop.
@sourcefrog
sftp mkdir "FAILURE" might just mean it exists
da64af7
@sourcefrog
More trace during
f15011d
@sourcefrog
refactor
fd992ef
@sourcefrog
Use ssh2-rs from upstream git
caf776c 
sftp fixes are in upstream master but not yet released
@sourcefrog
Update to released ssh library
f328a07
@sourcefrog
merge main
9afb00c
@sourcefrog
rm unused SshError
9ad5614 
SSH errors are now always reported through Transport
@sourcefrog
Merge branch 'main' into sftp
8e408b4
@sourcefrog
Merge branch 'backup-content-unchanged' into sftp
1e1b63c
@sourcefrog sourcefrog marked this pull request as ready for review October 14, 2024 00:43
@sourcefrog sourcefrog merged commit 94f20ca into main Oct 18, 2024
34 checks passed
@sourcefrog sourcefrog deleted the sftp branch October 18, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access repository over SFTP transport
1 participant
@sourcefrog