Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agentic-chat): fix prompt-mixin for deep-cody agent #6654

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Jan 15, 2025

  • Rename thePromptMixin.buildPrompt method to PromptMixin.join method
  • Refactor the PromptMixin.mixedMessage method to use PromptMixin.join method directly and simplify the logic

Test plan

Check output log. Added new unit tests.

- Rename the`PromptMixin.buildPrompt` method to `PromptMixin.join` method
- Refactor the `PromptMixin.mixedMessage` method to use `PromptMixin.join` method directly and simplify the logic
@abeatrix abeatrix requested a review from hitesh-1997 January 15, 2025 20:37
@abeatrix abeatrix requested a review from a team January 15, 2025 20:45
Copy link
Contributor

@hitesh-1997 hitesh-1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for fixing 🙌

- Added unit tests for the PromptMixin class to cover various scenarios
  including basic messages, messages with hedging prevention, deep-cody
  agent messages, messages with context mixin, and messages with
  multiple mixins
- Ensured the tests cover the expected behavior of the PromptMixin
  functionality
@abeatrix abeatrix enabled auto-merge (squash) January 15, 2025 21:04
@abeatrix abeatrix disabled auto-merge January 15, 2025 21:05
@abeatrix abeatrix merged commit 27e8acf into main Jan 16, 2025
20 of 21 checks passed
@abeatrix abeatrix deleted the bee/fix-agentic-prompt-mixin branch January 16, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants