Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProjectRoot format #473

Closed
qaqland opened this issue May 2, 2024 · 3 comments
Closed

ProjectRoot format #473

qaqland opened this issue May 2, 2024 · 3 comments
Assignees
@varungandhi-src
Labels
bug Something isn't working graph/scip-clang team/graph

Comments

@qaqland
Copy link

qaqland commented May 2, 2024

scip-clang/indexer/Driver.cc

Line 1049 in b7ecba1

metadata.set_project_root("file:/" + projectRootUnixStyle);

maybe it should be file://<path>, thus become compatible with "standard parsing" like go?

https://go.dev/play/p/nUzyrTnqeMX

reference:

sourcegraph/scip#98
@varungandhi-src
Copy link
Contributor

You're right, it should be file://

@varungandhi-src varungandhi-src added the bug Something isn't working label May 3, 2024
@varungandhi-src varungandhi-src self-assigned this May 3, 2024
@varungandhi-src
Copy link
Contributor

Opened PR here: #474

@qaqland
Copy link
Author

qaqland commented May 3, 2024

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varungandhi-src varungandhi-src

Labels
bug Something isn't working graph/scip-clang team/graph
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qaqland @varungandhi-src