Fix a regression where the SCIP index contained invalid symbols #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uploading an index with scip-java v0.8.17 results in the following error in the Sourcegraph UI ``` codeNavSvc.GetImplementations: lsifStore.MonikersByPosition: reached end of symbol while parsing <scheme>, expected a ' ' character minimized/Issue413Subclass#c. _____________________________^ ``` The problem is that this release introduced a regression where scip-java emitted invalid SCIP symbols. This PR fixes the issue, and adds new checks in the testing infrastructure to prevent this kind of regression from happening again.
keynmol
reviewed
May 3, 2023
Comment on lines
+22
to
+36
| scipSymbol.split(" ", 5) match { | ||
| case Array( | ||
| scheme, | ||
| packageManager, | ||
| packageName, | ||
| packageVersion, | ||
| descriptor | ||
| ) => | ||
| GlobalScipSymbol( | ||
| scheme, | ||
| packageManager, | ||
| packageName, | ||
| packageVersion, | ||
| parseDescriptors(descriptor) | ||
| ) |
There was a problem hiding this comment.
If we are targeting 2.13, I think you can use direct matching on a string here?
Suggested change
| scipSymbol.split(" ", 5) match { | |
| case Array( | |
| scheme, | |
| packageManager, | |
| packageName, | |
| packageVersion, | |
| descriptor | |
| ) => | |
| GlobalScipSymbol( | |
| scheme, | |
| packageManager, | |
| packageName, | |
| packageVersion, | |
| parseDescriptors(descriptor) | |
| ) | |
| scipSymbol match { | |
| case s"$scheme $packageManager $packageName $packageVersion $descriptor" => | |
| GlobalScipSymbol( | |
| scheme, | |
| packageManager, | |
| packageName, | |
| packageVersion, | |
| parseDescriptors(descriptor) | |
| ) |
I would check but my local is broken again. It's ridiculous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading an index with scip-java v0.8.17 results in the following error in the Sourcegraph UI
The problem is that this release introduced a regression where scip-java emitted invalid SCIP symbols. This PR fixes the issue, and adds new checks in the testing infrastructure to prevent this kind of regression from happening again.
Test plan
See updated snapshots.