Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and populate new SCIP SymbolInformation fields #677

Closed
wants to merge 9 commits into from
Closed

Add and populate new SCIP SymbolInformation fields #677

wants to merge 9 commits into from

Commits on Jan 10, 2024

  1. Update Document from upstream scip.proto 

    This copies the latest additions to the Document message:
 * a new language field and Language enum
 * a new text field, to embed the document content itself.
This is meant for the new SymbolInformation::signature_documentation
field.

This also updates some documentation comments.
    @nicolas-guichard
    nicolas-guichard committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    886a16e View commit details
    Browse the repository at this point in the history

  2. Update SymbolInformation from upstream scip.proto 

    This copies the latest additions to the SymbolInformation message:
 * the documentation field is explicitly not meant for signature
   documentation anymore, instead a new signature_documentation field
   is added
 * a new display_name field is added
 * a new enclosing_symbol field is added for local symbols
 * a new kind field is added along with a Kind enum to have a
   finer-grained classification than the one provided by descriptor
   suffixes (and is especially useful for local symbols which don't
   have suffixes)
    @nicolas-guichard
    nicolas-guichard committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    4dd3208 View commit details
    Browse the repository at this point in the history

  3. Forward display_name from SemanticDB to SCIP 

    The SemanticDB schema already provides a display_name field, forward it
to the SCIP output in scip-semanticdb.
This also adds support to the ScipPrinters testing utility and updates
the tests accordingly.
    @nicolas-guichard
    nicolas-guichard committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a0c7638 View commit details
    Browse the repository at this point in the history

  4. Move signature documentation to its new dedicated field 

    SemanticDB provides a structured version of the signature in the
signature field. Instead of turning it into a markdown-encoded string
for the documentation field, this builds a Document for the
signature_documentation field.

This also updates the ScipPrinters testing utility and the tests
accordingly.
    @nicolas-guichard
    nicolas-guichard committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    1ad2300 View commit details
    Browse the repository at this point in the history

  5. Add back SemanticDB SymbolInformation::owner field 

    SemanticDB used to have a SymbolInformation::owner field with id 15.
This re-introduces the field with the same semantics under the name
enclosing_symbol.

To be able to re-use the field 15, this moves the out-of-spec
definition_relationships field to id 21.
    @nicolas-guichard
    nicolas-guichard committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    6c10449 View commit details
    Browse the repository at this point in the history

  6. Forward enclosing_symbol from SemanticDB to SCIP 

    This also adds support to the ScipPrinters testing utility.
    @nicolas-guichard
    nicolas-guichard committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    5c27f4a View commit details
    Browse the repository at this point in the history

  7. Populate SymbolInformation::enclosing_symbol in semanticdb-javac 

    This only populates the enclosing_symbol for local symbols, and updates
the tests accordingly.
    @nicolas-guichard
    nicolas-guichard committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    8aef955 View commit details
    Browse the repository at this point in the history

  8. Build SCIP kind from SematicDB kind and properties 

    This also updates the ScipPrinters testing utility and the tests
accordingly.
    @nicolas-guichard
    nicolas-guichard committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f430a7c View commit details
    Browse the repository at this point in the history

  9. semanticdb-javac: set kind to Variable for local variables

    @nicolas-guichard
    nicolas-guichard committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    79875d1 View commit details
    Browse the repository at this point in the history