Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc comments for generated TypeScript bindings #39

Open
varungandhi-src opened this issue Jun 2, 2022 · 2 comments
Open

Doc comments for generated TypeScript bindings #39

varungandhi-src opened this issue Jun 2, 2022 · 2 comments

Comments

@varungandhi-src
Copy link
Contributor

varungandhi-src commented Jun 2, 2022

I noticed this weirdness after updating the doc comments and not noticing any change in the generated TypeScript bindings. 96b8a17

export enum SyntaxKind {
UnspecifiedSyntaxKind = 0,
Comment = 1,
PunctuationDelimiter = 2,
PunctuationBracket = 3,
IdentifierKeyword = 4,
IdentifierOperator = 5,
Identifier = 6,
IdentifierBuiltin = 7,
IdentifierNull = 8,
IdentifierConstant = 9,
IdentifierMutableGlobal = 10,
IdentifierParameter = 11,
IdentifierLocal = 12,
IdentifierShadowed = 13,
IdentifierModule = 14,
IdentifierFunction = 15,
IdentifierFunctionDefinition = 16,
IdentifierMacro = 17,
IdentifierMacroDefinition = 18,
IdentifierType = 19,
IdentifierBuiltinType = 20,
IdentifierAttribute = 21,
RegexEscape = 22,
RegexRepeated = 23,
RegexWildcard = 24,
RegexDelimiter = 25,
RegexJoin = 26,
StringLiteral = 27,
StringLiteralEscape = 28,
StringLiteralSpecial = 29,
StringLiteralKey = 30,
CharacterLiteral = 31,
NumericLiteral = 32,
BooleanLiteral = 33,
Tag = 34,
TagAttribute = 35,
TagDelimiter = 36
}

I wonder if there is a setting we can change (or a different compatible protobuf generator we can use) to make sure that doc comments are preserved. It feels a little weird that this doesn't work out-of-the-box. 😕

@varungandhi-src
Copy link
Contributor Author

Looks like this isn't implemented yet, they're looking for someone to help with implementation. thesayyn/protoc-gen-ts#118

@varungandhi-src
Copy link
Contributor Author

Related: #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant