cli: Replace docopt with urfave/cli. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue 25.
varungandhi-src
force-pushed
the
vg/use-urfave-cli
branch
from
d8b272c
to
82f31e4
Compare
varungandhi-src
commented
Jun 9, 2022
| fmt.Println("0.1.0") | ||
| os.Exit(0) | ||
| } | ||
| // FIXME: What is the right way to print help text and error here? |
There was a problem hiding this comment.
I should file an issue to fix this if we don't know a good way to fix this right now.
olafurpg
approved these changes
Jun 10, 2022
| {[]string{"convert", "--to=tmp.lsif"}, argMap{"--to": "tmp.lsif"}}, | ||
| {[]string{"convert", "--from=tmp.scip", "--to=tmp.lsif"}, argMap{"--from": "tmp.scip", "--to": "tmp.lsif"}}, | ||
| {[]string{"convert", "--to=tmp.lsif", "--from=tmp.scip"}, argMap{"--from": "tmp.scip", "--to": "tmp.lsif"}}, | ||
| func TestReadmeInSync(t *testing.T) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #25.
Test plan
Manually tested + updated existing tests. I'll add some follow-up tests as part of #19.