Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoekt: implement mode which has same behaviour as attribution search #613

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

zoekt: implement mode which has same behaviour as attribution search #613

wants to merge 6 commits into from

Commits on Jul 13, 2023

  1. zoekt: implement mode which has same behaviour as attribution search 

    This is to help reproduce slow attribution searches we have on
sourcegraph.com.
    @keegancsmith
    keegancsmith committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    51b6e52 View commit details
    Browse the repository at this point in the history

  2. zoekt: add fgprof for full profiling 

    Useful in local testing to capture both on and off cpu time spent.
Should consider shipping this in the webserver as well.

Test Plan: ran zoekt with -full_profile flag and inspected output in
pprof.
    @keegancsmith
    keegancsmith committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    4fa6cca View commit details
    Browse the repository at this point in the history

  3. zoekt: output run count summary

    @keegancsmith
    keegancsmith committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    e1ff3de View commit details
    Browse the repository at this point in the history

  4. make it possible to use in memory map

    @keegancsmith
    keegancsmith committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    076d554 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. sort ngrams before looking them up 

    We believe this will improve performance of the btree lookups.

Test Plan: go test ./...
    @keegancsmith
    keegancsmith committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b1b0f77 View commit details
    Browse the repository at this point in the history

  2. maybe: use sort.Search in btree inner nodes 

    keys only has a length of 50, so might not be faster.
    @keegancsmith
    keegancsmith committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    a6e726c View commit details
    Browse the repository at this point in the history