Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ngram offset code #616

Merged
merged 2 commits into from
Jul 17, 2023
Merged

remove ngram offset code #616

merged 2 commits into from
Jul 17, 2023

Commits on Jul 14, 2023

  1. remove ngram offset code 

    We have been running btree as the default for many months. We worried
about a performance hit, but it never happened. After some recent local
testing I did I noticed the btree actually interacted with the disk more
efficiently. So the old code both uses more memory and is slower, lets
just remove it.

Test Plan: go test ./...
    @keegancsmith
    keegancsmith committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    fb825fc View commit details
    Browse the repository at this point in the history

  2. remove intermediate ngramIndex interface and fileNameNgrams 

    This is no longer needed, we always use the btree. Additionally I added
some documentation.
    @keegancsmith
    keegancsmith committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    40d709a View commit details
    Browse the repository at this point in the history