all: remove deprecated RepoList.Minimal #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI there is this draft PR to remove the few places we read the field. These places only exist since they are general infra for aggregating, but in practice sourcegraph won't have this field populated. https://github.com/sourcegraph/sourcegraph/pull/54906 |
isker
reviewed
Jul 19, 2023
This field is no longer requested in Sourcegraph and has been deprecated for a while. Test Plan: go test ./...
keegancsmith
force-pushed
the
k/rm-minimal
branch
from
80aef13
to
44a0583
Compare
stefanhengl
approved these changes
Oct 9, 2023
| enum RepoListField { | ||
| reserved 2; |
There was a problem hiding this comment.
Do we need to add the field name to "reserved" as well? See here
There was a problem hiding this comment.
We don't use JSON serialization of these structs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is no longer requested in Sourcegraph and has been deprecated for a while.
Test Plan: go test ./...