Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove block profile rate config #818

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Remove block profile rate config #818

merged 1 commit into from
Sep 10, 2024

Conversation

jtibshirani
Copy link
Member

Tiny clean-up, as we rarely use Datadog profiling (and I've never heard of us setting this env var).

@cla-bot cla-bot bot added the cla-signed label Sep 9, 2024
@jtibshirani jtibshirani requested a review from a team September 9, 2024 18:25
@jtibshirani
Copy link
Member Author

Feel free to say "no don't remove this is useful"!

keegancsmith
keegancsmith approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI it isn't to do with datadog, they just host the best repo about tips and tricks about go's pprof support :)

But agree remove, looks like we regressed on setting it a long time ago.

@jtibshirani jtibshirani merged commit 44eab0c into main Sep 10, 2024
9 checks passed
@jtibshirani jtibshirani deleted the jtibs/profile branch September 10, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegancsmith keegancsmith keegancsmith approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtibshirani @keegancsmith