Skip to content

Commit

Permalink
fix rake test issues
Browse files Browse the repository at this point in the history
  • Loading branch information
nemanjar7 committed Dec 17, 2024
1 parent c578cae commit e57b192
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module Fastlane
module Actions
class MaestroOrchestrationIosAction < Action
def self.run(params)
required_params = [:simulator_name, :scheme, :workspace, :maestro_flow_file]
required_params = [:scheme, :workspace, :maestro_flow_file]
missing_params = required_params.select { |param| params[param].nil? }

if missing_params.any?
Expand Down
12 changes: 1 addition & 11 deletions spec/maestro_orchestration_action_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@
describe 'Parameter Passing' do
it 'makes sure that all the parameters are passed' do
valid_params = {
simulator_device: "iPhone 14",
scheme: "MyAppScheme",
workspace: "MyApp.xcworkspace",
maestro_flow_file: "flows.yaml"
}
%i[simulator_device scheme workspace maestro_flow_file].each do |key|
%i[scheme workspace maestro_flow_file].each do |key|
expect(valid_params[key]).not_to be_nil
end
end
Expand All @@ -21,15 +20,6 @@
expect { Fastlane::Actions::MaestroOrchestrationIosAction.run(invalid_params) }.to raise_error("Missing required parameters: maestro_flow_file")
end

it 'throws error if simulator_device is not provided' do
invalid_params = {
maestro_flow_file: "flows.yaml",
scheme: "MyAppScheme",
workspace: "MyApp.xcworkspace"
}
expect { Fastlane::Actions::MaestroOrchestrationIosAction.run(invalid_params) }.to raise_error("Missing required parameters: simulator_device")
end

it 'throws error if scheme is not provided' do
invalid_params = {
simulator_device: "iPhone 14",
Expand Down

0 comments on commit e57b192

Please sign in to comment.