Fix: Use fastlane 'adb' action instead of 'sh' command #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adb
action instead ofsh
. However, we still have to passadb_path
.sdk_path
from the ENV, to first check forANDROID_HOME
orANDROID_SDK_ROOT
, and only then it defaults to~/Library/Android/sdk
. It will save us some trouble if we end up redoingandroid-command-line-tools
installation, but even if we don't go that way it's still helpful for others.As an example, I am using all my sdk tools with homebrew (setup where all the tools are in
~/Library/Android/sdk/android-commandlinetools
, so I just added $ANDROID_HOME path.I am passing ENV['ANDROID_HOME'] here, but I assume we can do it in CI/CD as well, so it doesn't have to be in here.