Merge upstream -> mainline-criteo #822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Settle on the 'id' attribute as the attr_name for everything, since it is mandatory. - The xml method can now be shared (protected) with the parent class as it would be the same in every subclass. - Reduce the scope of the private key lookup. Due to the way Jenkins stores its credentials, it is quite hard to replicate this logic in integration tests without copying it entirely. As an exercise for later, stop reading credentials.xml and actually query Jenkins, but this is moving towards functional testing.
Make integration tests for credentials creation pass
When ignore_deps_versions is set to true, all plugin dependencies installed by the jenkins_plugin resource will be installed with their latest versions.
SSH slaves don't work on docker
Because of an runit issue, Jenkins is stopped after the end of the recipe, preventing the tests to be run.
Restore smoke testing in Travis CI
- New secret file credentials resource. - Allow empty passwords. - Apply ulimit when launching agents or master. - Apply style fixes.
- New secret file credentials resource. - Allow empty passwords. - Apply ulimit when launching agents or master. - Apply style fixes. - Remove extra double-quotes around -"remoting".
- New secret file credentials resource. - Allow empty passwords. - Apply ulimit when launching agents or master. - Apply style fixes. - Remove extra double-quotes around -"remoting".
Apply changes from criteo-forks to catchup with upstream
- This checksum property will be forwarded to chef remote file resource when retreiving the *.hpi/*.jpi plugin files.
It is not a good practice to apply remote_file resource without checksum, add this option here to allow end users add valid one.
Add "checksum" option for slave-jar remote_file resource
Without this attribute, an exception "NoMethodError" will be raised when we call "new_resource.checksum" to declare remote_file resource.
Add "checksum" attribute for JenkinsSlave resource
Specifically, to support our docker use case internally.
Allow specification of supplementary groups to start the JNLP slave with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.